Fixing check of 2x null-bytes ending REG_MULTI_SZ values

fortra · Aug 5, 2024 · 90724a5 · 90724a5
1 parent 170b542
commit 90724a5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/impacket/dcerpc/v5/rrp.py b/impacket/dcerpc/v5/rrp.py
@@ -702,9 +702,9 @@ def packValue(valueType, value):
             retData = value.decode(sys.getfilesystemencoding()).encode('utf-16le')
     elif valueType == REG_MULTI_SZ:
         try:
-            # REG_MULTI_SZ must end with 2 null-bytes
             v = checkNullString(value)
-            if v[-2:] != '\x00':
+            # REG_MULTI_SZ must end with 2 null-bytes
+            if v[-2:-1] != '\x00':
                 v = v + '\x00'
             retData = v.encode('utf-16le')
         except UnicodeDecodeError: