Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced MSSQLShell in NTLMRelayX leveraging TcpShell & output messages #1617

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

gabrielg5
Copy link
Collaborator

@gabrielg5 gabrielg5 commented Sep 15, 2023

This PR fixes #1612

Followed the same approach as it was followed in SMB / LDAP interactive shells.

Leveraging TcpShell to avoid mixing messages with the relay

Also have fixed an issue by which error messages of SQL commands were shown in the NTLMRelayX console, instead tha the SQLShell

Linked #1613

@gabrielg5 gabrielg5 self-assigned this Sep 15, 2023
@gabrielg5 gabrielg5 added the in review This issue or pull request is being analyzed label Sep 15, 2023
@gabrielg5
Copy link
Collaborator Author

Hey @sploutchy ,

If you wanna give it a try to this new version, would be really helpful!
let me know what you think
thank you!

@sploutchy
Copy link
Contributor

Hey @gabrielg5 ,
I tested this, it works great.
Thanks a lot.

@anadrianmanrique anadrianmanrique added the medium Medium priority item label Sep 21, 2023
@alexisbalbachan alexisbalbachan merged commit 2de2918 into fortra:master Oct 12, 2023
9 checks passed
abbra pushed a commit to abbra/impacket that referenced this pull request Nov 27, 2023
…es (fortra#1617)

* * Enhanced MSSQLShell in NTLMRelayX leveraging TcpShell (as in SMB and LDAP)

* * Created handle_lastError decorator applied to every command to show errors in the corresponding SQLShell
@gabrielg5 gabrielg5 deleted the interactive_sqlshell_fixes branch March 1, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review This issue or pull request is being analyzed medium Medium priority item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTLMRelayX] Interactive SQL shell breaks relay output
4 participants