Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADCS PKCS#12 clarification and formatting #1692

Closed
wants to merge 1 commit into from
Closed

ADCS PKCS#12 clarification and formatting #1692

wants to merge 1 commit into from

Conversation

Ernesto-Alvarez
Copy link

Slight clarification of what data is being returned on ADCS attack
Patch ADCS attack to limit line length on PKCS#12 data returned (to prevent clipboard problems w/overly long lines)

Slight clarification of what data is being returned on ADCS attack
e636ccf 
Patch ADCS attack to limit line length on PKCS#12 data returned (to prevent clipboard problems w/overly long lines)
@anadrianmanrique anadrianmanrique added in review This issue or pull request is being analyzed unicode_issue and removed unicode_issue labels Feb 1, 2024
@anadrianmanrique
Copy link
Contributor

Hi! thanks for the PR.
We were discussing about certificate output for ADCS. We think it would be nice to be consistent, and have for both, shadow credentials and ADCS , certificates dumped as files ( instead stdout for one and file for the other )
One item of this PR contemplates this #1439
Let us know your thoughts

@anadrianmanrique
Copy link
Contributor

see also #1440

@anadrianmanrique anadrianmanrique added the waiting for response Further information is needed from people who opened the issue or pull request label Feb 7, 2024
@anadrianmanrique
Copy link
Contributor

Closing this one. Changes related to this :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in review This issue or pull request is being analyzed waiting for response Further information is needed from people who opened the issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ernesto-Alvarez @anadrianmanrique