[enhancement] Adding column to show if SPN exists in finddelegations.py

[p0dalirius]

Hi,

I have added a new column "SPN Exists" to easily see if SPN Jacking is possible.

Here is a redacted example of output:

Best regards,

[gabrielg5]

Hi @p0dalirius,

Checking your changes I found a path that is triggering an error when generating the output.

This line is not setting any value to the new column

impacket/examples/findDelegation.py

Line 228 in 269ce69

answers.append([rights, objType, 'Resource-Based Constrained', sAMAccountName])

which is resulting in an exception iterating rows to draw the table

impacket/examples/findDelegation.py

Lines 40 to 44 in 269ce69

	def printTable(items, header):
	colLen = []
	for i, col in enumerate(header):
	rowMaxLen = max([len(row[i]) for row in items])
	colLen.append(max(rowMaxLen, len(col)))

Also, could you revert those quoting changes? that makes the PR more atomic and helps validate what is the real change

thank you!!

[p0dalirius]

Hi @gabrielg5,

I have fixed the code path

I have reverted the quoting changes, although the code really should be double quoted and not single quoted everywhere.

Best regards,

[gabrielg5]

Hey @p0dalirius,

great! just one last ask before merging this PR... Can you extract the spnExists resolution to an external function to avoid duplicating those lines?

thank you!

[p0dalirius]

Done :)

[gabrielg5]

Merging now..
Thank you!