Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: use install_subdir #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zoziha
Copy link
Contributor

@zoziha zoziha commented Jul 6, 2023

Description

  • When minpack is the main meson project, using install-mod.py to install the *.mod file, meson install will be expected.
  • When minpack is a meson subprojects project, installing the *.mod file using install-mod.py will have an unexpected effect.

The solution is to use meson's install_subdir, which I have used in several of my own projects and it meets all the requirements for a normal *.mod install.

@zoziha zoziha marked this pull request as draft July 6, 2023 12:55
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #79 (0627e39) into main (c0b5aea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files           2        2           
  Lines        1224     1224           
  Branches      456      456           
=======================================
  Hits         1087     1087           
  Misses         40       40           
  Partials       97       97           

@zoziha zoziha marked this pull request as ready for review July 6, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant