Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(ui): adds teardown process for Install tests #1011

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Nov 27, 2023

The mocking for UI tests is rather difficult to control.
Notifications pop-up in all sorts of orders. This PR aims to somewhat help with that. We might have to edit how the assertions work to make this more robust.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4540f6) 83.64% compared to head (28042fe) 83.64%.

❗ Current head 28042fe differs from pull request most recent head 717d511. Consider uploading reports for the commit 717d511 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files          12       12           
  Lines        2311     2311           
  Branches      205      205           
=======================================
  Hits         1933     1933           
  Misses        373      373           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnikit gnikit merged commit dc25e4c into main Nov 27, 2023
2 checks passed
@gnikit gnikit deleted the maint/ui-tests branch November 27, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant