fix bug in updates with extra fields

fortunejs · Oct 13, 2018 · 6d74caa · 6d74caa
1 parent e2c21f9
commit 6d74caa
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 
 
+##### 1.6.8 (2018-10-13)
+- Fix: do not allow extraneous fields in update to cause silent error.
+
+
 ##### 1.6.7 (2018-09-26)
 - Polish: make authorization parameters in connection URL optional.
 

diff --git a/lib/index.js b/lib/index.js
@@ -441,6 +441,7 @@ module.exports = Adapter => class PostgreSQLAdapter extends Adapter {
     const client = this.client
     const typeMap = this.options.typeMap
     const primaryKey = this.keys.primary
+    const recordTypes = this.recordTypes
 
     // This is a little bit wrong, it is only safe to update within a
     // transaction. It's not possible to put it all in one update statement,
@@ -451,6 +452,7 @@ module.exports = Adapter => class PostgreSQLAdapter extends Adapter {
       let set = []
 
       for (const field in update.replace) {
+        if (!(field in recordTypes[type])) continue
         const value = update.replace[field]
         index++
         if (Array.isArray(value)) parameters.push(value.map(inputValue))
@@ -459,6 +461,7 @@ module.exports = Adapter => class PostgreSQLAdapter extends Adapter {
       }
 
       for (const field in update.push) {
+        if (!(field in recordTypes[type])) continue
         const value = update.push[field]
         index++
 
@@ -473,6 +476,7 @@ module.exports = Adapter => class PostgreSQLAdapter extends Adapter {
       }
 
       for (const field in update.pull) {
+        if (!(field in recordTypes[type])) continue
         const value = update.pull[field]
 
         if (Array.isArray(value)) {
@@ -489,6 +493,8 @@ module.exports = Adapter => class PostgreSQLAdapter extends Adapter {
         set.push(`"${field}" = array_remove("${field}", $${index})`)
       }
 
+      // When no fields are to be updated, it's a no-op.
+      if (!set.length) return resolve(0)
 
       set = `set ${set.join(', ')}`
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "fortune-postgres",
   "description": "Postgres adapter for Fortune.",
-  "version": "1.6.7",
+  "version": "1.6.8",
   "license": "MIT",
   "repository": {
     "type": "git",