Revert "fix: change default integration_api to 3004" #1459
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1281. It makes absolutely no sense that Pangolin uses ports 3000-3002, skips 3003, and uses 3004. Gerbil should have been changed instead. This is a particularly annoying inconsistency as it prevents me from elegantly mapping the default pangolin ports in a functional language if I have to arbitrarily skip a number:
https://github.com/NixOS/nixpkgs/blob/da9f816ee7211d180eb1bc28f22358b9668b5fbe/nixos/modules/services/networking/pangolin/default.nix#L375-L395
fosrl/gerbil#28