-
-
Notifications
You must be signed in to change notification settings - Fork 440
Patch logger for ISO8601 TZ offsets and Docker build fix #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- server/logger.ts: timestamps now use local TZ offset instead of Z - Dockerfile: replaced 'npm ci --omit=dev' with 'npm install --omit=dev' to fix Alpine build failure - References discussion: https://github.com/orgs/fosrl/discussions/1025 - Note: timestamps default to +00:00 (UTC) unless the user sets environment: TZ=<timezone> in docker-compose.yaml Optional future improvement: include tzdata in the container for shell/date consistency.
- server/logger.ts: timestamps now use local TZ offset instead of Z - Dockerfile: replaced 'npm ci --omit=dev' with 'npm install --omit=dev' to fix Alpine build failure - References discussion: https://github.com/orgs/fosrl/discussions/1025 - Note: timestamps default to +00:00 (UTC) unless the user sets environment: TZ=<timezone> in docker-compose.yaml Optional future improvement: include tzdata in the container for shell/date consistency.
Thanks for this! I think the Dockerfile should stay the same like I commented above but otherwise fix seems good thanks for this so much! Please also include the CLA in the text of your pull request or comment it down below. For convenience:
|
I added above in the first comments; I assume that is sufficient? And you're welcome. It looks like FWIW, and I'm not sure this was clear:
|
This seems to work! I dont think adding the tzdata in is really a problem so I went ahead and included that. |
@iconoclasthero maybe you could include some documentation in the docs? I think maybe under advanced configuration? |
|
Patch logger for ISO8601 timestamps with local TZ offset and fix Docker build failure on Alpine.
References discussion: https://github.com/orgs/fosrl/discussions/1025
Note: timestamps default to +00:00 (UTC) unless TZ env is set and match timestamp format of traefik
Optional future improvement: include tzdata in container for shell/date consistency.
By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content.