Potential fix for Server-side request forgery #1948
+50
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description (generated by Copilot)
See https://codeql.github.com/codeql-query-help/javascript/js-request-forgery/
Code generated by Copilot
This pull request introduces stricter validation for organization and resource identifiers to improve security and consistency across API endpoints. The main changes add UUID format checks for organization IDs in license-related routes and type guard functions for resource and identity provider IDs in server-side actions, with corresponding input validation in proxy functions.
Validation improvements for organization IDs:
orgIdingenerateNewLicense.ts, ensuring only valid organization IDs are accepted when generating new licenses. [1] [2]listGeneratedLicenses.tsto requireorgIdto match a UUID v4 pattern, rejecting invalid or missing organization IDs with a clear error message.Security enhancements in server-side actions:
isValidResourceIdandisValidIdpIdtype guard functions inserver.tsto validate resource and identity provider IDs, restricting accepted formats.resourcePasswordProxy,resourcePincodeProxy,resourceWhitelistProxy,resourceAccessProxy,validateOidcUrlCallbackProxy,generateOidcUrlProxy), throwing errors for invalid IDs to prevent unsafe requests. [1] [2] [3] [4] [5] [6]orgIdingenerateOidcUrlProxyto further strengthen input validation.How to test?