Change added as a speaker email #142
Conversation
odkhang
changed the title
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @odkhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a test case to verify the new email content is generated correctly.
- Please clarify if you've manually tested this change, for example by sending a test email.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| You have been set as the speaker of a proposal to the Call for Participation | ||
| of {event}, titled “{title}”. An account has been created for you – please follow | ||
| this link to set your account password. | ||
| We are excited to inform you that you have been selected as a speaker for {event} with your proposal titled "{title}". |
There was a problem hiding this comment.
nitpick: Consider using single quotes for consistency.
The rest of the code appears to use single quotes for strings. For consistency and to avoid potential issues, it might be better to use single quotes here as well.
| We look forward to your participation and contribution to {event}. | ||
|
|
||
| Best regards, | ||
| The {event} Organizing Team""" |
There was a problem hiding this comment.
suggestion: Consider using a consistent term for the organizing team.
In the subject line, 'orga' is used, while in the body, 'Organizing Team' is used. It might be better to use a consistent term throughout the email for clarity.
| The {event} Organizing Team""" | |
| The {event} Orga Team""" |
There was a problem hiding this comment.
Yes, good catch. Please use "Organizing Team"
There was a problem hiding this comment.
Got it, thanks for the clarification, @mariobehling. I'll update the suggestion to use "Organizing Team" consistently throughout the email. Here's the revised suggestion:
| The {event} Organizing Team""" | |
| Best regards, | |
| The {event} Organizing Team""" |
I'll make this change in the code.
| @@ -102,7 +104,7 @@ | |||
| event=submission.event, | |||
| reply_to=submission.event.email, | |||
| subject=str( | |||
| _("You have been added to a proposal for {event}").format( | |||
| _("Welcome as a Speaker at {event}!").format( | |||
There was a problem hiding this comment.
suggestion: Consider rephrasing the subject line for clarity.
The subject line 'Welcome as a Speaker at {event}!' could be rephrased to 'Welcome as a Speaker for {event}!' to improve clarity and readability.
| _("Welcome as a Speaker at {event}!").format( | |
| _("Welcome as a Speaker for {event}!").format( |
There was a problem hiding this comment.
We have skipped reviewing this pull request. It looks like we've already reviewed the commit 0a19adf in this pull request.
|
Hi @mariobehling, Please help me review this PR |
|
|
|
It looks like you are testing the wrong email. This email is for adding a co-speaker. |
This PR references issue #138. In the submission.py change the existing email to the new version.
How has this been tested?
Checklist
Summary by Sourcery
This pull request updates the email template used to notify speakers about their proposal acceptance, enhancing the tone and clarity of the message.