fix: status bar displays black icons instead of white. #3028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideSets the system status bar icon brightness to light (white icons) across multiple configuration and scaffold screens by updating each AppBar’s SystemUiOverlayStyle configuration. Flow diagram for AppBar system overlay style with light status bar iconsgraph TD
User["User opens any config or scaffold screen"] --> FlutterApp
FlutterApp --> ScreenState
ScreenState --> AppBar
AppBar --> SystemUiOverlayStyle
SystemUiOverlayStyle -->|statusBarColor appBarColor| AndroidStatusBar
SystemUiOverlayStyle -->|statusBarIconBrightness Brightness.light| AndroidStatusBar
AndroidStatusBar["Android system status bar"] --> RenderedStatusBar["Rendered status bar with white icons"]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- You’re repeating the same
SystemUiOverlayStyleconfiguration across many screens; consider extracting a shared helper or constant (e.g.whiteStatusBarOverlay) to keep this DRY and easier to change later. - On iOS,
statusBarBrightnessis used instead ofstatusBarIconBrightness, so you may want to set both fields inSystemUiOverlayStyleto ensure consistent behavior across platforms.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You’re repeating the same `SystemUiOverlayStyle` configuration across many screens; consider extracting a shared helper or constant (e.g. `whiteStatusBarOverlay`) to keep this DRY and easier to change later.
- On iOS, `statusBarBrightness` is used instead of `statusBarIconBrightness`, so you may want to set both fields in `SystemUiOverlayStyle` to ensure consistent behavior across platforms.
## Individual Comments
### Comment 1
<location> `lib/view/accelerometer_config_screen.dart:50-55` </location>
<code_context>
resizeToAvoidBottomInset: true,
appBar: AppBar(
- systemOverlayStyle: SystemUiOverlayStyle(statusBarColor: appBarColor),
+ systemOverlayStyle: SystemUiOverlayStyle(
+ statusBarColor: appBarColor,
+ statusBarIconBrightness: Brightness.light,
+ ),
leading: Builder(builder: (context) {
</code_context>
<issue_to_address>
**suggestion:** Consider also setting `statusBarBrightness` for consistent behavior on iOS.
Currently only `statusBarIconBrightness` is set, which mainly impacts Android. On iOS, `statusBarBrightness` is what controls the status bar style. To keep appearance consistent across platforms, set both fields with values that work with `appBarColor` and the desired contrast.
```suggestion
appBar: AppBar(
systemOverlayStyle: SystemUiOverlayStyle(
statusBarColor: appBarColor,
statusBarIconBrightness: Brightness.light,
statusBarBrightness: Brightness.dark,
),
leading: Builder(builder: (context) {
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Build StatusBuild successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/20828828404/artifacts/5067473450. ScreenshotsAndroid Screenshots
iPhone Screenshots
iPad Screenshots
|
||||||||||||||||||||||||
-1_instruments_screen.png?raw=true)
-2_nav_drawer.png?raw=true)
-3_accelerometer.png?raw=true)
-4_power_source.png?raw=true)
-5_multimeter.png?raw=true)
-6_wave_generator.png?raw=true)
-7_oscilloscope.png?raw=true)
Yugesh-Kumar-S
force-pushed
the
status-bar
branch
from
da1145d to
4d71853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2906
Changes
Changed status bar icon color to white.
Screenshots / Recordings
Before:
After:
Checklist:
constants.dartor localization files instead of hard-coded values.dart formator the IDE formatter.flutter analyzeand tests run influtter test.Summary by Sourcery
Bug Fixes: