-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #275 Add Codecov reports #276
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhaveshAn , what I can understand is that is something similar to codacy.Please explain the need.
@stealthanthrax Please don't suggest changes/ review the PR, if you are not clear about a feature. NeedCodecov is a reporting tool that is intended to process any coverage report format into a format that is standard across Codecov. You may change the configuration of how Codecov processes reports and expresses coverage information. The Codecov pull request comment is a highly detailed overview of a pull request. It provides details on the coverage changes in the pull request that help with speeding up code review, and ensuring that pull requests are well tested. The comment is customizable to fit your desired needs. SamplesCheckout the PRs of https://github.com/fossasia/susper.com/pulls and https://github.com/fossasia/open-event-server/pulls for example. Here projects uses coverage changes in the pull request that help with speeding up code review, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats your thought @zamhaq |
@ms10398 Yeah, I think we should. |
@zamhaq I guess that this PR can wait for some time. We do have to split the script.js file into multiple files for better modularity. So till then, this can be put on a hold. Else it will cause problems for new PRs. |
ok so you guys are working on that? @gabru-md cool. Thanks 😄 |
Will start working on that too! |
Any updates on this? |
@prateekiiest This was put on hold because of on-going work on #156 and idk about the current status according to gsoc about which are priority issues now. |
Fixes #275
Checklist
master
branch.Short description of what this resolves:
Added Codecov reports
Changes proposed in this pull request:
codecov.yml
@zamhaq @ms10398 @mariobehling Please review.