Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #275 Add Codecov reports #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #275 Add Codecov reports #276

wants to merge 1 commit into from

Conversation

bhaveshAn
Copy link
Member

Fixes #275

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Added Codecov reports

Changes proposed in this pull request:

  • Added codecov.yml
  • Modify Travis.

@zamhaq @ms10398 @mariobehling Please review.

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhaveshAn , what I can understand is that is something similar to codacy.Please explain the need.

@bhaveshAn
Copy link
Member Author

bhaveshAn commented Jan 16, 2018

@stealthanthrax Please don't suggest changes/ review the PR, if you are not clear about a feature.
Instead simply make the comment.

Need

Codecov is a reporting tool that is intended to process any coverage report format into a format that is standard across Codecov. You may change the configuration of how Codecov processes reports and expresses coverage information.

The Codecov pull request comment is a highly detailed overview of a pull request. It provides details on the coverage changes in the pull request that help with speeding up code review, and ensuring that pull requests are well tested. The comment is customizable to fit your desired needs.

Samples

Checkout the PRs of https://github.com/fossasia/susper.com/pulls and https://github.com/fossasia/open-event-server/pulls for example. Here projects uses coverage changes in the pull request that help with speeding up code review,

Copy link
Member

@haquezameer haquezameer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms10398 @gabru-md codecov should be included?

@ms10398
Copy link
Member

ms10398 commented Jan 21, 2018

Whats your thought @zamhaq

@haquezameer
Copy link
Member

@ms10398 Yeah, I think we should.

@gabru-md
Copy link
Member

@zamhaq I guess that this PR can wait for some time. We do have to split the script.js file into multiple files for better modularity. So till then, this can be put on a hold. Else it will cause problems for new PRs.
Once we are done with splitting the file, then I support that this should be merged.
Rest is your thoughts! and your final take :)

@haquezameer
Copy link
Member

ok so you guys are working on that? @gabru-md cool. Thanks 😄

@gabru-md
Copy link
Member

Will start working on that too!
Meanwhile can you please see #287 and merge?

@prateekiiest
Copy link
Member

Any updates on this?

@haquezameer
Copy link
Member

@prateekiiest This was put on hold because of on-going work on #156 and idk about the current status according to gsoc about which are priority issues now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Codecov reports
6 participants