Fixes #431 Make textarea expand automatically #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyamtg
changed the title
fragm3
requested changes
Oct 14, 2018
rossoskull
reviewed
Oct 14, 2018
There was a problem hiding this comment.
Agree with @fragm3. Maybe you can increase the size for 2-3 lines, but not more than that 🤔
akshatnitd
requested changes
Oct 21, 2018
| function resizeTextarea(){ | ||
| var element = this; | ||
| setTimeout(function(){ | ||
| element.style.cssText = "height:auto"; |
There was a problem hiding this comment.
You can do this upto 3 lines as suggested by others. For this put a max height and set overflow-y : auto in the CSS.
There was a problem hiding this comment.
@satyamtg can you please look into the changes pointed by akshat.
Once done please ask for a review again. thank you
There was a problem hiding this comment.
@satyamtg can you please look into the changes pointed by akshat.
Once done please ask for a review again. thank you
ms10398
requested changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #431
Checklist
masterbranch.Short description of what this resolves:
This makes the textarea to type messages expand and contract vertically according to the size of message which is being typed in real time. This makes reviewing the messages before posting them easier as compared to previous scrollbar implementation.
Changes proposed in this pull request:
-Make textarea to type messages expand and contract vertically according to the size of the message being typed.