-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting "success" only when some option is selected and submit is clicked in settings #525
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill the details in the PR description.
Also, provide a GIF or Image.
@samagragupta I have filled the details in PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a more descriptive class name.
Rest looks good.
@samagragupta I have changed the class name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill the issue number. Use descriptive variable names, indent the code properly
Fixes #
Checklist
master
branch.Short description of what this resolves:
Previously in settings page when user clicks Submit button without actually changing the Message Pane Colour or Predefined themes it shows a success message.
But now success message will only be displayed when some different colour or theme is selected.
Changes proposed in this pull request: