Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting "success" only when some option is selected and submit is clicked in settings #525

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Puranjay25
Copy link

@Puranjay25 Puranjay25 commented Jan 15, 2019

Fixes #

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Previously in settings page when user clicks Submit button without actually changing the Message Pane Colour or Predefined themes it shows a success message.
But now success message will only be displayed when some different colour or theme is selected.

Changes proposed in this pull request:

Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill the details in the PR description.
Also, provide a GIF or Image.

@Puranjay25
Copy link
Author

@samagragupta I have filled the details in PR description

Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a more descriptive class name.
Rest looks good.

@Puranjay25
Copy link
Author

@samagragupta I have changed the class name

Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill the issue number. Use descriptive variable names, indent the code properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants