Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only one colorpicker is opening at a time. #532

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Only one colorpicker is opening at a time. #532

wants to merge 9 commits into from

Conversation

Puranjay25
Copy link

Fixes #475

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

hide

@Puranjay25 Puranjay25 changed the title Now only one colorpicker is opening at a time. Only one colorpicker is opening at a time. Jan 20, 2019
@fossasia fossasia deleted a comment Jan 20, 2019
@fossasia fossasia deleted a comment Jan 20, 2019
@fossasia fossasia deleted a comment Jan 20, 2019
@fossasia fossasia deleted a comment Jan 20, 2019
@fossasia fossasia deleted a comment Jan 20, 2019
neeraj3029
neeraj3029 reviewed Jan 30, 2019
View reviewed changes
Copy link
Member

@neeraj3029 neeraj3029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neeraj3029 neeraj3029 neeraj3029 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One colorpicker should close automatically when other is opened
2 participants
@Puranjay25 @neeraj3029