Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:- Account Section Implementation. #561

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

baquer
Copy link
Member

@baquer baquer commented May 28, 2019

Fixes #559, #544, #557

Screenshots for the change:

Screenshot 2019-06-03 at 3 03 58 AM

@baquer
Copy link
Member Author

baquer commented Jun 2, 2019

@chashmeetsingh, @jogendra, Please Review the PR

@baquer baquer changed the title [WIP] Account Section Implementation. Feat:- Account Section Implementation. Jun 2, 2019
@baquer
Copy link
Member Author

baquer commented Jun 5, 2019

Updated SS

Screenshot 2019-06-05 at 6 35 59 PM

@jogendra, please review and merge this PR. Will solve Other issues related to this PR in other PRs.

Copy link
Member

@jogendra jogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the UI:

  • There should be option to change avatar from clicking the image.
  • AspectFit image in avatar imageView
  • Align delete button left and keep it just below last textField.
  • Add shadow of radius 10 to the avatar imageview and keep border white color

@baquer
Copy link
Member Author

baquer commented Jun 5, 2019

For the UI:

  • There should be option to change avatar from clicking the image.
  • AspectFit image in avatar imageView
  • Align delete button left and keep it just below last textField.
  • Add shadow of radius 10 to the avatar imageview and keep border white color

@jogendra, I will do the changes, just to be clear I am thinking of implementing the upload Avatar or image in a different storyboard where user can pick either gravatar, avatar or Image from the gallery by clicking the image view just like we have in our Susi web app. And that's the reason why I made a click button in the account settings storyboard that redirects to the upload image storyboard because making all the things in a single storyboard is somewhat messy.
@jogendra and @chashmeetsingh what's your view on this?

@jogendra
Copy link
Member

jogendra commented Jun 6, 2019

I think if you are not adding any additional functionality other than just uploading image then, it will be good to do in same controller

@baquer
Copy link
Member Author

baquer commented Jun 6, 2019

I think if you are not adding any additional functionality other than just uploading image then, it will be good to do in same controller

Yes, I am thinking of implementing the user dashboard in the same storyboard.

@baquer
Copy link
Member Author

baquer commented Jun 6, 2019

For the UI:

  • There should be option to change avatar from clicking the image.
  • AspectFit image in avatar imageView
  • Align delete button left and keep it just below last textField.
  • Add shadow of radius 10 to the avatar imageview and keep border white color

Changes are done @jogendra, I changed the shadow of radius to 2 because if we change it to 10 then it is overlapping with the user Image
Screenshot 2019-06-07 at 3 10 27 AM

Here is the updated SS

Screenshot 2019-06-07 at 3 16 37 AM

@jogendra
Copy link
Member

jogendra commented Jun 7, 2019

I changed the shadow of radius to 2 because if we change it to 10 then it is overlapping with the user Image

Add outer shadow, not inner!

@baquer
Copy link
Member Author

baquer commented Jun 7, 2019

I changed the shadow of radius to 2 because if we change it to 10 then it is overlapping with the user Image

Add outer shadow, not inner!

Done @jogendra

Here is the output

Screenshot 2019-06-07 at 5 55 26 PM

@baquer
Copy link
Member Author

baquer commented Jun 10, 2019

@jogendra, please review

Copy link
Member

@jogendra jogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update M13Checkbox Pod, it is giving me the errors.

@baquer
Copy link
Member Author

baquer commented Jun 14, 2019

Update M13Checkbox Pod, it is giving me the errors.

Done @jogendra

@jogendra
Copy link
Member

jogendra commented Jul 5, 2019

@baquer
Copy link
Member Author

baquer commented Jul 5, 2019

@baquer Have you followed https://stackoverflow.com/questions/26024100/dyld-library-not-loaded-rpath-libswiftcore-dylib to fix the Lint error?

@jogendra Yes I tried almost every answer, but none of them are working, I think the problem is either with the WWDRCA certificate or with the Circle CI integration. I will try to solve this within this week

@baquer
Copy link
Member Author

baquer commented Jul 5, 2019

@jogendra On Circle Ci Website I found out this warning "Your project references CircleCI 1.0 or it has no configuration. CircleCI 1.0 and projects without configuration files are no longer supported. You must update your project to use CircleCI 2.0 configuration to continue."

@jogendra
Copy link
Member

jogendra commented Jul 5, 2019

@baquer We are using version 2. May be change some cofig params or xcode version to get it done.

@baquer
Copy link
Member Author

baquer commented Jul 6, 2019

@baquer We are using version 2. May be change some cofig params or xcode version to get it done.

@jogendra Okay I will try to fix this by changing parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI/UX for Account View Controller.
2 participants