Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox to pytest #188

Merged
merged 23 commits into from
Oct 6, 2024
Merged

Tox to pytest #188

merged 23 commits into from
Oct 6, 2024

Conversation

hkkim2021
Copy link
Contributor

@hkkim2021 hkkim2021 commented Sep 27, 2024

Description

Refactoring the test commands defined in the original tox.ini to use pytest.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@hkkim2021 hkkim2021 force-pushed the tox_to_pytest branch 4 times, most recently from 2e94115 to a8f4e21 Compare September 27, 2024 14:51
@hkkim2021 hkkim2021 marked this pull request as ready for review September 28, 2024 02:22
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Sep 28, 2024
@hkkim2021 hkkim2021 force-pushed the tox_to_pytest branch 6 times, most recently from 332b0fe to 0cd0891 Compare September 30, 2024 01:38
Signed-off-by: hkkim <[email protected]>
Copy link

@cjho0316 cjho0316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 수고하셨습니다!

Copy link

@ena-isme ena-isme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다 :)

Copy link

@MoonJeWoong MoonJeWoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ 코멘트 단 부분만 확인해주시고 의견 부탁드립니다! 🙇

Copy link
Contributor

@YongGoose YongGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하게 잘 작성하셨네요!
고생하셨습니다 :)

Copy link

@s-cu-bot s-cu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특이사항은 없는 것 같습니다. 고생하셨습니다~

Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
3
Signed-off-by: hkkim <[email protected]>
4
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
Signed-off-by: hkkim <[email protected]>
@soimkim soimkim merged commit ad2dec2 into fosslight:main Oct 6, 2024
7 checks passed
@soimkim
Copy link
Contributor

soimkim commented Oct 6, 2024

@hkkim2021 , 고생하셨습니당! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants