-
Notifications
You must be signed in to change notification settings - Fork 16
Enable fastsafetensors to support the Paddle #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fastsafetensors to support the Paddle #16
Conversation
|
@zeroRains I would like to merge this immediately after we confirm no regressions on both pytorch and paddle, and then, we can clean up the change as separate patches later as v0.1.14. I would like to ask you two things:
|
|
Thank you for your recognition. The current version can read tensors successfully by executing each unittest command . However, it gets stuck at the end of a unittest command (possibly related to my failure to install nvidia-fs successfully. If it's convenient for you, please try to see if there is the same problem). I still need to check again then I will share the When all the modifications are completed, all commits will be rebase into one commit. |
|
@zeroRains |
|
I have rebased all commit to one commit. |
|
I forget to add paddlepaddle-gpu as dependency to pyproject.toml. Maybe we should retrigger the test. |
7dcb82a to
d150e5d
Compare
|
thanks. maybe there are issues around package installations. Please note that we do not have GPUs on test machines. |
|
@zeroRains |
@takeshi-yoshimura Sorry, I misunderstood what you meant before, I will check the pr soon then merge it. |
|
@takeshi-yoshimura Hello, I have merged the pr and rebase all commit to one. |
|
@zeroRains |
support for paddle support gloo in cpu case try nccl in gpu case update test case fix the bug in nccl support gds fix merge bug add paddle unittest confuse about test_memmove fix uint16 add the paddlepaddle-gpu to project.toml paddlepaddle set 3.0 version paddlepaddle-gpu==3.0.0 should install from www.paddlepaddle.org.cn remove cpp.cpythonxxx.so add paddle_loaded Signed-off-by: Takeshi Yoshimura <[email protected]> Signed-off-by: zeroRains <[email protected]>
|
@takeshi-yoshimura I have run it. |
6ef7687
into
foundation-model-stack:main
|
finally I have merged your commit to main. I will keep updating code, but anyway, thank you very much for your contribution! |
|
@takeshi-yoshimura Hello, Are there any plans to release the fastsafetensors version supporting paddle on PyPI in the near future? If so, could you please inform us of the time? |
|
@zeroRains |
|
@takeshi-yoshimura Sorry, I find that distributed loading has not been fully verified yet. I need to test it. Later, I will resubmit a PR regarding distributed fixes. |
Environment:
I support fastsaftensors run with paddle.
Write 2 example cases in examples/padle_case (single and parallel).
Add all unitest for paddle.