Fix paddle.distributed.broadcast/scatter from async to sync #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeroRains <[email protected]>
takeshi-yoshimura
merged commit dd4f237
into
foundation-model-stack:main
11 of 13 checks passed
Collaborator
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to disturb you again.
I use the async mode in
paddle.distributed.broadcastandpaddle.distributed.scatter(main branch).In fact, it can not load complete tensor then output when load a huge tensor. Because there is not enough time to load a huge tensor in async mode. Maybe when we are broadcasting, the tensor has been used .
Now, I change the async mode to sync mode so that we can load a huge tensor successfully.