Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github workflows #3

Merged
merged 10 commits into from
Jan 30, 2024
Merged

add github workflows #3

merged 10 commits into from
Jan 30, 2024

Conversation

nairbv
Copy link
Contributor

@nairbv nairbv commented Jan 30, 2024

just copied from fms and changed target, should basically be the same here.

Copy link
Collaborator

@JRosenkranz JRosenkranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@JRosenkranz JRosenkranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment regarding name


- name: Test with pytest
run: |
mypy --exclude hf --exclude testing fms-extras
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be fms_extras

@nairbv nairbv merged commit 5ff2246 into main Jan 30, 2024
2 of 3 checks passed
@nairbv
Copy link
Contributor Author

nairbv commented Jan 30, 2024

merging despite test failures. failure error is 5 meaning no tests found. it'll work on any new branch adding tests (and the next thing to land will have tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants