add tuning/config/configs unit tests #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedhtchang
requested review from
anhuong,
Ssukriti and
alex-jw-brooks
as code owners
tharapalanivel
requested changes
Mar 11, 2024
Signed-off-by: ted chang <[email protected]>
|
@tharapalanivel I realized your PR#83 already test the configs module. I should close this PR unless you have examples of edges configs you want me to test. |
gkumbhat
reviewed
Mar 19, 2024
|
|
||
|
|
||
| def test_model_argument_configs_default(): | ||
| data_arguments = tuning_config.DataArguments |
There was a problem hiding this comment.
nit: can you add docstrings to these tests describing their goal and scope
|
@tedhtchang can we close this PR if it has duplicative unit tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds unit tests for tuning.config.configs modules
Related issue number
Closes #72
How to verify the PR
git clone https://github.com/tedhtchang/fms-hf-tuning.git -b add-configs-unit-tests cd ms-hf-tuning pytest tests/configs/test_configs.pyWas the PR tested