Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing rule after rebooting nodes #5

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix missing rule after rebooting nodes #5

merged 1 commit into from
Aug 5, 2022

Conversation

sunya-ch
Copy link
Collaborator

@sunya-ch sunya-ch commented Aug 4, 2022

This PR fixes the following issues after rebooting a node.

  • Table ID remains while the rule and routes are all deleted. The previous implementation checks if table ID and add rule only if the table is deleted. This PR also checks if the rule exists and add rule if it is missing.
  • Instead of waiting for synchronization period (10 minutes), after node is rebooted, the updated pod will invoke the call SyncCIDRRouteToHost. If it is failed, it will update Unknown status to MultiNICNetwork. MultiNICNetwork reconcile loop will reconcile the resource until route is successfully sync.

Signed-off-by: Sunyanan Choochotkaew [email protected]

@sunya-ch
add rule to sync step, sync existing CIDR for new daemon pod, and rec…
5d54732 
…oncile multinicnetwork for failed route status

Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@tatsuhirochiba tatsuhirochiba merged commit 7e3062b into main Aug 5, 2022
@sunya-ch sunya-ch deleted the opt branch February 1, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunya-ch @tatsuhirochiba