Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement build-push ci #8

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

sunya-ch
Copy link
Collaborator

@sunya-ch sunya-ch commented Sep 6, 2022

This PR mainly implements GitHub Action workflows for automatically building and pushing controller, bundle, and daemon images to the repository.

There are three workflows:

  • build_push_controller: build and push controller and its bundle images
  • build_push_daemon: build CNI, move to daemon local folder, and build and push daemon image
  • unittest: run test for controller

To avoid unnecessary build and push,

  • The code changes related to controller should be pushed to controller branch first to execute build_push_controller.
  • Similarly, the code changes related to daemon should be pushed to daemon branch to execute build_push_daemon.
  • As any change related to CI pipelines might affect image build and push, the first two workflows will be also executed on ci branch.

The unittest will be executed for all branches except explicitly non-related doc branch.

Detail modifications:

  • to reduce confusion, re-add prefix (multi-nic-cni-) to the image name
  • update daemon/CNI Makefile to suppress folder not found error
  • update operator-sdk to latest version (v1.23.0)

Signed-off-by: Sunyanan Choochotkaew [email protected]

Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@tatsuhirochiba tatsuhirochiba merged commit 269059d into foundation-model-stack:ci Sep 6, 2022
@tatsuhirochiba
Copy link
Collaborator

Thanks for quick implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants