Skip to content

Update README with edge case information #65

Merged
evaline-ju merged 6 commits intofoundation-model-stack:mainfrom
swith004:README_edge_case
Apr 21, 2025
Merged

Update README with edge case information #65
evaline-ju merged 6 commits intofoundation-model-stack:mainfrom
swith004:README_edge_case

Conversation

@swith004
Copy link
Copy Markdown
Collaborator

This PR Updates the readme to show edge cases for the detector apis with respect to supported model versions.

Signed-off-by: Shonda Witherspoon <shonda.adena.witherspoon@Shondas-MacBook-Pro.local>
@swith004 swith004 marked this pull request as ready for review April 18, 2025 20:46
@swith004 swith004 requested review from evaline-ju and gkumbhat April 21, 2025 13:59
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated

| Model | /api/v1/text/contents | /api/v1/text/generation | /api/v1/text/chat | /api/v1/text/context/doc |
|------------------|-----------------------|-------------------------|-------------------|--------------------------|
| granite guardian | &check; | &check; | &check; | * |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering instead of the indirection with the *, perhaps just a reference to 3.2 supported inline e.g. "only 3.2 version"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good alternative - I agree that makes sense as a change

Comment thread README.md Outdated
swith004 and others added 5 commits April 21, 2025 11:48
Co-authored-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: swith004 <switherspoon004@gmail.com>
Co-authored-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: swith004 <switherspoon004@gmail.com>
Co-authored-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: swith004 <switherspoon004@gmail.com>
Co-authored-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: swith004 <switherspoon004@gmail.com>
Signed-off-by: Shonda Witherspoon <shonda.adena.witherspoon@Shondas-MacBook-Pro.local>
@swith004 swith004 requested a review from evaline-ju April 21, 2025 16:01
Copy link
Copy Markdown
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evaline-ju evaline-ju merged commit 9b9e7b0 into foundation-model-stack:main Apr 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPIKE] Explore chat template analysis for Granite Guardian's context_relevance risk

2 participants