lmp/build: adapt post-build processing to scarthgap #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Validated with |
quaresmajose
force-pushed
the
license
branch
2 times, most recently
from
433915d
to
d57120e
Compare
quaresmajose
force-pushed
the
license
branch
2 times, most recently
from
df8154b
to
4df8310
Compare
|
In this case the file not exist and so the glob will not expand |
quaresmajose
force-pushed
the
license
branch
from
4df8310
to
4c9335b
Compare
|
What causes the image manifest to not be generated? |
|
Good question, it could be that it is generated with a different name but I don't know. |
|
instead of having a message we can make this an error and so it becomes clearer what happened. |
|
We had working lmp-base ci runs before as well, which is why the question. |
|
I will debug it more to get the reason. |
quaresmajose
force-pushed
the
license
branch
8 times, most recently
from
25a2d72
to
283ca9d
Compare
quaresmajose
force-pushed
the
license
branch
4 times, most recently
from
551add8
to
cc39f3a
Compare
- Skip the loop if the disto image manifest not exist
- Fail if the manifest file pattern not exist
- Consider only the symbolic links of the images manifest
- From the licenses deploy dir of the image:
- Copy the license.manifest, if not possible fail
- Copy the image_license.manifest
| + for img in ${DEPLOY_DIR_IMAGE}/*${MACHINE}.manifest
| ++ basename '/srv/oe/build/deploy/images/intel-corei7-64/*intel-corei7-64.manifest'
| ++ sed -e s/.manifest//
| + image_name='*intel-corei7-64'
| ++ readlink '/srv/oe/build/deploy/images/intel-corei7-64/*intel-corei7-64.manifest'
| ++ sed -e 's/\..*manifest//'
| + image_name_id=
| Script completed with error(s)
Signed-off-by: Jose Quaresma <[email protected]>
There is a bug in oe-core and sometimes the lic folder is empty. https://bugzilla.yoctoproject.org/show_bug.cgi?id=15394 The intention of this change is to document and be reverted once the problem is fixed. Signed-off-by: Jose Quaresma <[email protected]>
quaresmajose
changed the title
Use find to get the packages with GPL licenses, because there are bsp with a diferent deploy licenses directory tree and with find we make it independent of the directory tree. Signed-off-by: Jose Quaresma <[email protected]>
It will be usefull for debug broken builds Signed-off-by: Jose Quaresma <[email protected]>
|
I will do all of this scarthgap adapt in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lmp/build: check availability of the image manifest
lmp/build: don't fail when the license.manifest not found
There is a bug in oe-core and sometimes the lic folder is empty.
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15394
The intention of this change is to document and be reverted once
the problem is fixed.