lmp/bb-build: clarify the bitbake notification

[quaresmajose]

• add notification about the end
• change the finish notification to post processing

When there are errors during the bitbake build it is always necessary to perform some additional post-processing steps such as:

== Run bitbake (finish)
== Run bitbake (rsync factory sstate-cache mirror)

Script completed with error(s)

Only after this last step is reported that there was an error. This leads the user to think that the error was in the last step, in this case the rsync, which is not true.

Example:

Summary: 1 task failed:
  /srv/oe/build/conf/../../layers/meta-subscriber-overrides/recipes-samples/images/lmp-factory-image.bb:do_image_garagecheck
Summary: There were 4 WARNING messages.
Summary: There was 1 ERROR message, returning a non-zero exit code.
== 2024-10-10 12:00:20 Run bitbake (finish)
bootchart written to '/archive/bitbake_buildchart.svg'
== 2024-10-10 12:00:24 Run bitbake (rsync factory sstate-cache mirror)
 Script completed with error(s)
== 2024-10-10 12:01:32.828429: Finding artifacts to upload Uploading 14 items 53779607 bytes
== 2024-10-10 12:01:36.053422: Runner has completed
          ________
          |  o  o|           Thumbs Down
          |___/\_|________
          |       _____|__|
          |      |     ||
          |______|
          | |  | |
          | |  | |
          |_|  |_|

[angolini]

I think I understand the goal of the PR. It is only to add a log line to the end of bitbake execution, not to specify where the error is.

In the PR/commit log it's "bitbake finish" and in the source code it's "bitbake done"

[quaresmajose]

I think I understand the goal of the PR. It is only to add a log line to the end of bitbake execution, not to specify where the error is.

right

In the PR/commit log it's "bitbake finish" and in the source code it's "bitbake done"

what I wanted to notify with these steps was the following:

• Run bitbake (finish): where the post-processing will be executed
• Run bitbake (rsync factory sstate-cache mirror): where we keep the sstate-cache
• Run bitbake (done): signal the end of execution

maybe I could use other words for this instead of having finish/rsync/done

[MrCry0]

LGTM. Nice improvement, I personally was confused some times by such error message at the end of the log :)

[angolini]

I don't know either. I think finish and done is misleading out of context

what about

Run bitbake (starting post-processing): where the post-processing will be executed
Run bitbake (rsync factory sstate-cache mirror): where we keep the sstate-cache
Run bitbake (done): signal the end of execution

[quaresmajose]

I don't know either. I think finish and done is misleading out of context

what about

Run bitbake (starting post-processing): where the post-processing will be executed
Run bitbake (rsync factory sstate-cache mirror): where we keep the sstate-cache
Run bitbake (done): signal the end of execution

done

[ricardosalveti]

LGTM