offline-updates: Allow specification of local ostree repo #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mike-sul please take a look. I can't add reviewers to the PR. |
detsch
force-pushed
the
detsch-add-ostree-repo-source
branch
from
47696c0
to
0ab88cd
Compare
mike-sul
reviewed
Nov 5, 2024
mike-sul
reviewed
Nov 5, 2024
mike-sul
reviewed
Nov 5, 2024
mike-sul
reviewed
Nov 5, 2024
mike-sul
reviewed
Nov 5, 2024
detsch
force-pushed
the
detsch-add-ostree-repo-source
branch
3 times, most recently
from
f7f56c0
to
2a65e9f
Compare
mike-sul
reviewed
Nov 12, 2024
mike-sul
approved these changes
Nov 12, 2024
|
@doanac I think it is worth to include this into the short-coming release too. |
|
yes. we should include this |
This option allows a local ostree repo to be specified as replacement for the factory ostree repo when building the offline bundle. This if required when a custom ostree repo was pushed with `fiopush` and a target was was manually added referencing a hash from this custom repo. Signed-off-by: Andre Detsch <[email protected]>
When a target was manually added with `fioctl targets add`, it may reference an ostree hash that is not included the factory's repo. An offline bundle created in such condition would fail installation. Signed-off-by: Andre Detsch <[email protected]>
detsch
force-pushed
the
detsch-add-ostree-repo-source
branch
from
2a65e9f
to
7725750
Compare
|
I think it is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the specification of a local ostree repo during offline bundle creation is required when a custom ostree repo is in use (
fiopush+fioctl targets add).This PR also add a warning message if the ostree repo does not contain the expected hash.