targets: Handle OrigUri and OrigUriApps when adding targets #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For custom apps targets, origUri must be set, while uri and origUriApps must be empty. For custom ostree targets, origUriApps must be set, while uri and origUri must be empty. Signed-off-by: Andre Detsch <[email protected]>
detsch
force-pushed
the
detsch-fix-orig-uri
branch
from
ba0553b
to
363f6a8
Compare
mike-sul
approved these changes
Nov 15, 2024
If by "CI" do you mean the publish job/run, then setting both If |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For custom apps targets, origUri must be set, while uri and origUriApps must be empty.
For custom ostree targets, origUriApps must be set, while uri and origUri must be empty.
@mike-sul this change seems to work, but is not enough. Apps targets generated by our CI are keeping the
origUriAppsfield set. I'd say we need to fix the behavior there before merging this change to fioctl. Otherwise, an oldorigUriAppsvalue is carried on indefinitely.