-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preprocessor to skip recompiling tests on non-interface source file changes #252
base: main
Are you sure you want to change the base?
Conversation
1c02f7f
to
325a627
Compare
325a627
to
0f78197
Compare
b4c0746
to
7d0edb8
Compare
b5ebece
to
4025e5a
Compare
be6c378
to
d37cafb
Compare
b605610
to
6a81147
Compare
6954c27
to
322e80a
Compare
2bcd743
to
e16fe89
Compare
the win panic is related to the fact in compilers we normalize sources when reading but then we read them again from disk in Solar locs get out of sync. e.g. with this commit e16fe89 the preprocessor test that panic before pass (https://github.com/foundry-rs/compilers/actions/runs/14091283691/job/39468341793#step:7:708) however there are some flatten related test failing now thanks both! |
You can manually load sources with "dummy" isn't right, it's just a way to intern a source file with a String rather than loading from disk |
e16fe89
to
62f2933
Compare
62f2933
to
446a5d8
Compare
Awesome, that worked, committed in 446a5d8 |
supersedes #198
closes #197
Implements preprocessor allowing us to skip recompiling tests on non-interface source file changes. Still testing, but looks like it's working correctly, decreasing single-change build times from ~1 minute to 5s in some cases.
TODOs
Depends on