fix: encode transaction without signature in impersonated_hash #12793
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found an issue where impersonated_hash was encoding the full transaction including the signature, which doesn't match how regular transaction hashing works in Ethereum. Changed it to encode just the transaction data (without signature) first, then append the sender address - same pattern as the standard hash() method. This keeps things consistent with Ethereum standards while still making sure impersonated transactions get unique hashes even when they share the same fake signature. Why this matters: - All impersonated txs use the same fake signature, so encoding with signature would give identical hashes for identical tx data - Ethereum tx hashing excludes signatures by design - Consistency with hash() makes the code easier to reason about
PivasDesant
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Dec 10, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this seems alright but is also a bit pointless because this will never be correct encoding because we append the impersonated address as well.
but since this is "less wrong" I think we can do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue where impersonated_hash was encoding the full transaction including the signature, which doesn't match how regular transaction hashing works in Ethereum.
Changed it to encode just the transaction data (without signature) first, then append the sender address - same pattern as the standard hash() method. This keeps things consistent with Ethereum standards while still making sure impersonated transactions get unique hashes even when they share the same fake signature.
Why this matters: