[WIP] Static localizations should be ready. Missing config-based ones.#25
Open
ccjmk wants to merge 1 commit into
Open
[WIP] Static localizations should be ready. Missing config-based ones.#25ccjmk wants to merge 1 commit into
ccjmk wants to merge 1 commit into
Conversation
cswendrowski
approved these changes
May 4, 2023
Contributor
cswendrowski
left a comment
cswendrowski
left a comment
There was a problem hiding this comment.
Looking really good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All dynamic i18n localizations intentionally prefixed with "`BF[" just to find them more easily. Looking for feedback on the namespacing and the multiple-file structure initially.