Skip to content

Add a parameter to hide /act skill label #21525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cuingamehtar wants to merge 1 commit into
base: v14-dev
Choose a base branch
from
+12 −4
Open

Add a parameter to hide /act skill label #21525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/module/system/text-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,15 +449,21 @@ class TextEditorPF2e extends foundry.applications.ux.TextEditor {
// statistic
const statistic = (params["statistic"] || params["stat"] || params["skill"])?.trim();

if ((dc && showDC) || statistic) {
// "false" or "never" to never show
const showStatisticOverride = (params["show-statistic"] || params["show-stat"] || params["show-skill"])
?.trim()
.toLowerCase();
const showStatistic = statistic && !(showStatisticOverride === "false" || showStatisticOverride === "never");

if ((dc && showDC) || showStatistic) {
element.appendChild(document.createTextNode(" "));

const details = document.createElement("span");
if (dc && showDC) {
if (!Number.isNumeric(dc)) {
// (Statistic vs Defense DC)
const defense = game.i18n.localize(`PF2E.Check.DC.Specific.${dc}`);
const text = statistic
const text = showStatistic
? game.i18n.format("PF2E.InlineAction.Check.StatisticVsDefense", {
defense,
statistic: ActionMacroHelpers.getSimpleCheckLabel(statistic) || statistic,
Expand All @@ -470,15 +476,17 @@ class TextEditorPF2e extends foundry.applications.ux.TextEditor {
dataset: { visibility },
children: [game.i18n.format("PF2E.InlineAction.Check.DC", { dc })],
});
const end = statistic ? ` ${ActionMacroHelpers.getSimpleCheckLabel(statistic) || statistic})` : ")";
const end = showStatistic
? ` ${ActionMacroHelpers.getSimpleCheckLabel(statistic) || statistic})`
: ")";
details.append("(", span, end);
} else {
// <span data-visibility="...">(DC #)</span>
details.dataset.visibility = visibility;
details.innerText = `(${game.i18n.format("PF2E.InlineAction.Check.DC", { dc })})`;
}
} else {
// (Statistic)
// (showStatistic)
const text = ActionMacroHelpers.getSimpleCheckLabel(statistic) || statistic;
details.innerText = `(${text})`;
}
Expand Down