Skip to content

Add defense filter to Compendium Browser spell tab #21526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
In3luki wants to merge 1 commit into
base: v13-dev
Choose a base branch
from
Open

Add defense filter to Compendium Browser spell tab #21526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/module/apps/compendium-browser/tabs/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ interface HazardFilters extends BaseFilterData {
interface SpellFilters extends BaseFilterData {
checkboxes: {
category: CheckboxData;
defense: CheckboxData;
rank: CheckboxData;
rarity: CheckboxData;
traditions: CheckboxData;
Expand Down
33 changes: 32 additions & 1 deletion src/module/apps/compendium-browser/tabs/spell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export class CompendiumBrowserSpellTab extends CompendiumBrowserTab {
const publications = new Set<string>();
const indexFields = [
"img",
"system.defense",
"system.level.value",
"system.time",
"system.traits",
Expand Down Expand Up @@ -91,6 +92,12 @@ export class CompendiumBrowserSpellTab extends CompendiumBrowserTab {
system.time.value = normalizedTime;
options.push(`time:${normalizedTime}`);
}
const defense = system.defense;
if (defense?.save)
options.push(`defense:save:${defense.save.basic ? "basic:" : ""}${defense.save.statistic}`);
if (defense?.passive) options.push(`defense:passive:${defense.passive.statistic.split("-")[0]}`);
if (!defense && options.includes(`trait:attack`) && !options.includes("category:ritual"))
options.push(`defense:passive:armor`);

spells.push({
name: spellData.name,
Expand Down Expand Up @@ -133,7 +140,25 @@ export class CompendiumBrowserSpellTab extends CompendiumBrowserTab {
},
{ sort: false },
);

this.filterData.checkboxes.defense.options = {
...this.generateCheckboxOptions(
R.mapValues(CONFIG.PF2E.saves, (l) =>
game.i18n.format("PF2E.CompendiumBrowser.Filter.Spells.Defense.BasicWithSave", {
save: game.i18n.localize(l),
}),
),
{
prefix: "save:basic",
},
),
...this.generateCheckboxOptions(CONFIG.PF2E.saves, { prefix: "save" }),
...this.generateCheckboxOptions(
R.pick(CONFIG.PF2E.checkDCs.Specific, ["armor", "fortitude", "reflex", "will"]),
{
prefix: "passive",
},
),
};
this.filterData.selects.timefilter.options = [...times].sort().reduce(
(result, time) => ({
...result,
Expand Down Expand Up @@ -167,6 +192,12 @@ export class CompendiumBrowserSpellTab extends CompendiumBrowserTab {
options: {},
selected: [],
},
defense: {
isExpanded: false,
label: "PF2E.Item.Spell.Defense.Label",
options: {},
selected: [],
},
rarity: {
isExpanded: false,
label: "PF2E.CompendiumBrowser.Filter.Rarities",
Expand Down
5 changes: 5 additions & 0 deletions static/lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,11 @@
"Rarities": "Rarities",
"Sizes": "Sizes",
"Source": "Sources",
"Spells": {
"Defense": {
"BasicWithSave": "Basic {save}"
}
},
"Traditions": "Traditions",
"WeaponFilters": "Weapon Filters",
"SearchPlaceholder": "Search Text",
Expand Down