Skip to content

Convert AncestrySystemData to DataModel#22035

Open
In3luki wants to merge 1 commit intofoundryvtt:v14-devfrom
In3luki:ancestry-data-model
Open

Convert AncestrySystemData to DataModel#22035
In3luki wants to merge 1 commit intofoundryvtt:v14-devfrom
In3luki:ancestry-data-model

Conversation

@In3luki
Copy link
Copy Markdown
Collaborator

@In3luki In3luki commented Apr 15, 2026

Getting in some practice before going for a bigger one. No errors in my test world.

@stwlam
Copy link
Copy Markdown
Collaborator

stwlam commented Apr 15, 2026

We need to make sure that the model cleaning isn't going to hit before a system migration.

Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
@In3luki In3luki force-pushed the ancestry-data-model branch from 6d1c432 to 6886fd0 Compare April 16, 2026 06:11
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
Comment thread src/module/item/ancestry/data.ts Outdated
@In3luki In3luki force-pushed the ancestry-data-model branch from 6886fd0 to 41aa578 Compare April 16, 2026 20:04
@In3luki
Copy link
Copy Markdown
Collaborator Author

In3luki commented Apr 16, 2026

I've been experimenting with data model migrations again but I can't get the unpruned source values to stick around long enough to be available for the system migration. There are some new levers with DataModel._preCleanData and the new DataModelCleaningOptions but setting prune: false doesn't seem to do anything. When the source hits my ancestry test migration (system.speed to system.speed2) the original source value is gone and only values defined in the data schema remain..
I've tried overriding in the ItemSystemModel and in ActorPF2e but that didn't do anything either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants