Skip to content

Fix Predicate Input Label on Effects in Aura Rules#22071

Open
websterguy wants to merge 1 commit intofoundryvtt:v14-devfrom
websterguy:aura-predicate-label
Open

Fix Predicate Input Label on Effects in Aura Rules#22071
websterguy wants to merge 1 commit intofoundryvtt:v14-devfrom
websterguy:aura-predicate-label

Conversation

@websterguy
Copy link
Copy Markdown
Contributor

No description provided.

@CarlosFdez
Copy link
Copy Markdown
Collaborator

CarlosFdez commented Apr 18, 2026

I looked into the code, this might address the symptoms well enough, but it looks like the problem is that the effect's own predicate field does not have the predicate label assigned in the data model

@websterguy
Copy link
Copy Markdown
Contributor Author

websterguy commented Apr 18, 2026

It's true that the PredicateField doesn't have an explicit label set, but neither does any other new PredicateField that I can see. If you would rather, I can set it for this instance instead of the posted fix. I confirmed it does fix it as well.

@CarlosFdez
Copy link
Copy Markdown
Collaborator

Most of them are set by LOCALIZATION_PREFIXES. But the stuff in the aura effects explicitly set a label property. I think PredicateField could maybe have a label set by default.

@websterguy
Copy link
Copy Markdown
Contributor Author

websterguy commented Apr 19, 2026

It looks like setting a label in the constructor of PredicateField causes some other forms to fail to localize it.

image

Could be an autogenerated forms issue, as some of them still seem to work. Should I just set the label explicitly in the new PredicateField in effectSchemaField for the predicate in the effects tab of the aura?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants