Skip to content

[WIP] Prevent land-derived speeds from receiving bonuses twice from same source#22173

Open
iDantar wants to merge 3 commits intofoundryvtt:v14-devfrom
iDantar:21570-prevent-pushing-wind-from-double-buffing-fly-speed
Open

[WIP] Prevent land-derived speeds from receiving bonuses twice from same source#22173
iDantar wants to merge 3 commits intofoundryvtt:v14-devfrom
iDantar:21570-prevent-pushing-wind-from-double-buffing-fly-speed

Conversation

@iDantar
Copy link
Copy Markdown
Collaborator

@iDantar iDantar commented Apr 28, 2026

Closes #21570

Changes:

  • Made sure each speed derived from land is marked so
  • Only treat speed as derived if formula evaluation is equal to land speed (e.g. max(60, land-speed) is only derived if land speed is 60+)
  • FlatModifierRuleElement would now skip applying a bonus to land-derived speed if it already affected land speed

@iDantar iDantar added pr: data update Updates to existing actors and items pf2e labels Apr 28, 2026
@iDantar iDantar changed the title Pushing wind buff fly speed only once Ensure Pushing Wind fly speed buff applies only once Apr 28, 2026
@TikaelSol
Copy link
Copy Markdown
Collaborator

This is a more generic standing issue with bonuses stacking in speeds. Not sure we should tackle this in data.

@iDantar
Copy link
Copy Markdown
Collaborator Author

iDantar commented Apr 29, 2026

I'll see if that's something I can solve, thanks

@iDantar iDantar changed the title Ensure Pushing Wind fly speed buff applies only once Prevent land-derived speeds from receiving bonuses twice from same source May 2, 2026
@iDantar iDantar added pr: bugfix pr: refactor and removed pr: data update Updates to existing actors and items pf2e labels May 2, 2026
@iDantar
Copy link
Copy Markdown
Collaborator Author

iDantar commented May 2, 2026

I tried a generic fix - it feels a bit rough, so would appreciate any suggestions :)

@CarlosFdez
Copy link
Copy Markdown
Collaborator

Double test heavy armor penalties, as well as negation via several feats.

@iDantar iDantar changed the title Prevent land-derived speeds from receiving bonuses twice from same source [WIP] Prevent land-derived speeds from receiving bonuses twice from same source May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pushing Wind Duplicated Bonus

3 participants