Skip to content

Update Base Document Types#22216

Open
7H3LaughingMan wants to merge 7 commits intofoundryvtt:v14-devfrom
7H3LaughingMan:base-documents
Open

Update Base Document Types#22216
7H3LaughingMan wants to merge 7 commits intofoundryvtt:v14-devfrom
7H3LaughingMan:base-documents

Conversation

@7H3LaughingMan
Copy link
Copy Markdown
Contributor

This is another attempt at #22127 since I borked the PR with a rebase.

Comment thread types/foundry/common/documents/chat-message.d.mts Outdated
Comment thread types/foundry/common/documents/chat-message.d.mts Outdated
Comment thread types/foundry/common/documents/ambient-light.d.mts
Comment thread types/foundry/common/documents/card.d.mts Outdated
Comment thread types/foundry/common/documents/chat-message.d.mts Outdated
Comment thread types/foundry/common/documents/item.d.mts Outdated
Comment thread types/foundry/common/documents/item.d.mts Outdated
Comment thread types/foundry/common/documents/item.d.mts Outdated
@7H3LaughingMan 7H3LaughingMan marked this pull request as draft May 4, 2026 03:45
@7H3LaughingMan
Copy link
Copy Markdown
Contributor Author

Alright, so I was dumb and didn't realize all the comments for the schema properties were in common/documents/_types.mjs so I was doing a hodgepodge of already existing comments and "standardizing" them without realizing there was a source for them. I copied over the comments and everything should be good.

There are some exceptions I wanted to point out, most of these are from the data in core being outdated and some fields missing. If you want me to remove these let me know.

  • There were a couple of documents that were missing _stats and so I just put An object of creation and access information to match all the documents that aren't missing them
  • There were a couple of documents that were missing levels or level, so I put The level IDs or The level ID to match
  • ChatMessage has a author but core has a user so I just used the description from user
  • FogExploration is missing the level so I just used The _id of the Level document to which this fog applies which matches the same format as user and scene
  • Scene actually has a typo for folder and sort, they both mention this Actor which is obviously wrong and I changed them to this Scene

Other than that I left Level alone since that one doesn't contain any property description for some reason

@7H3LaughingMan 7H3LaughingMan marked this pull request as ready for review May 4, 2026 05:28
@stwlam
Copy link
Copy Markdown
Collaborator

stwlam commented May 4, 2026

Yep, no editorializing under any circumstance.

@7H3LaughingMan
Copy link
Copy Markdown
Contributor Author

Alright, there we go the only comments are from the property descriptions defined in core, if they aren't defined they aren't there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants