Display Heritages in the Features Tab#22249
Open
iDantar wants to merge 1 commit intofoundryvtt:v14-devfrom
Open
Display Heritages in the Features Tab#22249iDantar wants to merge 1 commit intofoundryvtt:v14-devfrom
iDantar wants to merge 1 commit intofoundryvtt:v14-devfrom
Conversation
CarlosFdez
reviewed
May 7, 2026
| level: null, | ||
| feat: actor.heritage, | ||
| children: this.#getNestedSlots(actor.heritage), | ||
| } as never); |
Collaborator
There was a problem hiding this comment.
avoid casting to never. There's gotta be another way.
CarlosFdez
reviewed
May 7, 2026
| @@ -247,6 +247,9 @@ class CharacterFeats<TActor extends CharacterPF2e> extends Collection<string, Fe | |||
| if (granter?.isOfType("feat") && granter.grants.includes(feat) && isNested) { | |||
Collaborator
There was a problem hiding this comment.
What is the practicality of including the heritage in granter.grants? It looks like grants in FeatPF2e is FeatPF2e | HeritagePF2e, so doing granter?.isOfType("feat", "heritage") && granter.grants.includes(feat) && isNested should be more terse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22235
Supersedes #22233
Inserts the heritage in Ancestry Features list and renders it's nested feats, if any.
Some examples: