Skip to content

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Jul 12, 2024

Add a basic devcontainer configuration and CI to pre-build it. Other Dissect projects can re-use it like so:

{
	"name": "Dissect",
	"image": "ghcr.io/fox-it/dissect-devcontainer",
	"postCreateCommand": "pip3 install --user --editable . --config-settings editable_mode=compat"
	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
	// "remoteUser": "root"
}

Or '.[dev]' is that project has one.

@Schamper Schamper requested a review from Miauwkeru May 21, 2025 14:37
Copy link

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes that I just spotted

@Miauwkeru
Copy link

If we add pull_request to the on: too, we can have a pipeline for the PRs and see if it actually succeeds in building the image. In the case we make changes to the whole things

Co-authored-by: Miauwkeru <[email protected]>
Copy link

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schamper Schamper merged commit b0833b1 into main May 22, 2025
1 check passed
@Schamper Schamper deleted the add-devcontainer-config branch May 22, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants