Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vmdk extent descriptor parsing #44

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Oct 23, 2024

This PR improves the parsing of VMDK config strings, particularly extent descriptors. We introduced a new ExtentDescriptor dataclass to conveniently store all possible attributes of an extent. Fixes #45.

dissect/hypervisor/disk/vmdk.py Outdated Show resolved Hide resolved
dissect/hypervisor/disk/vmdk.py Outdated Show resolved Hide resolved
dissect/hypervisor/disk/vmdk.py Outdated Show resolved Hide resolved
tests/test_vmdk.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.

Project coverage is 63.11%. Comparing base (98a9a66) to head (80afc8e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/hypervisor/disk/vmdk.py 70.45% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   61.62%   63.11%   +1.48%     
==========================================
  Files          27       27              
  Lines        2356     2375      +19     
==========================================
+ Hits         1452     1499      +47     
+ Misses        904      876      -28     
Flag Coverage Δ
unittests 63.11% <70.45%> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dissect/hypervisor/disk/vmdk.py Outdated Show resolved Hide resolved
tests/test_vmdk.py Outdated Show resolved Hide resolved
dissect/hypervisor/disk/vmdk.py Outdated Show resolved Hide resolved
@Schamper Schamper merged commit 8ad6252 into fox-it:main Oct 28, 2024
18 checks passed
Miauwkeru added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMDK extent descriptors with more than four values cannot be parsed
2 participants