-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve vmdk extent descriptor parsing #44
Merged
Schamper
merged 3 commits into
fox-it:main
from
JSCU-CNI:improvement/vmdk-extent-descriptors
Oct 28, 2024
Merged
Improve vmdk extent descriptor parsing #44
Schamper
merged 3 commits into
fox-it:main
from
JSCU-CNI:improvement/vmdk-extent-descriptors
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
requested changes
Oct 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 61.62% 63.11% +1.48%
==========================================
Files 27 27
Lines 2356 2375 +19
==========================================
+ Hits 1452 1499 +47
+ Misses 904 876 -28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Oct 25, 2024
Co-authored-by: Erik Schamper <[email protected]>
Schamper
approved these changes
Oct 28, 2024
Miauwkeru
added a commit
that referenced
this pull request
Nov 14, 2024
This reverts commit 8ad6252.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the parsing of VMDK config strings, particularly extent descriptors. We introduced a new
ExtentDescriptor
dataclass to conveniently store all possible attributes of an extent. Fixes #45.