Refactor: enabled None

fox-it · Sep 20, 2024 · 7b50abd · 7b50abd
1 parent ddadd1e
commit 7b50abd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/dissect/target/plugins/os/windows/network.py b/dissect/target/plugins/os/windows/network.py
@@ -345,7 +345,7 @@ def _extract_network_device_config(
             static_config["search_domain"] = [static_domain]
 
         if len(static_config) > 0:
-            static_config["enabled"] = static_config == 0
+            static_config["enabled"] = None
             static_config["dhcp"] = False
 
         # Combine ip and subnetmask for extraction

diff --git a/tests/plugins/os/windows/test_network.py b/tests/plugins/os/windows/test_network.py
@@ -85,7 +85,7 @@ class MockRegVal:
                 "search_domain": ["local"],
                 "metric": 5,
                 "dhcp": False,
-                "enabled": False,
+                "enabled": None,
             },
         ),
         (
@@ -108,7 +108,7 @@ class MockRegVal:
                 "name": None,
                 "metric": None,
                 "dhcp": False,
-                "enabled": False,
+                "enabled": None,
             },
         ),
         (
@@ -141,7 +141,7 @@ class MockRegVal:
                 "metric": None,
                 "name": None,
                 "dhcp": False,
-                "enabled": False,
+                "enabled": None,
             },
         ),
     ],
@@ -289,7 +289,7 @@ def test_windows_network_none(
                     "search_domain": ["corp"],
                     "metric": 20,
                     "dhcp": False,
-                    "enabled": False,
+                    "enabled": None,
                 },
             ],
         ),