Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for MSSQL error log files #823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fox-evv
Copy link

@fox-evv fox-evv commented Aug 15, 2024

This can show e.g. that xp_cmdshell was enabled

fox-evv and others added 2 commits August 15, 2024 16:16
This can show e.g. that xp_cmdshell was enabled
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.62%. Comparing base (a9d723b) to head (750d186).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/log/mssql.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
+ Coverage   75.40%   75.62%   +0.21%     
==========================================
  Files         302      312      +10     
  Lines       26152    26577     +425     
==========================================
+ Hits        19720    20098     +378     
- Misses       6432     6479      +47     
Flag Coverage Δ
unittests 75.62% <97.29%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic self-assigned this Sep 9, 2024
@Horofic Horofic self-requested a review September 9, 2024 11:46
Copy link
Contributor

@Horofic Horofic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions and added some tests with a commit. Please test in your own environment to see if the suggestions hold up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants