Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows network interface plugin #830

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Add Windows network interface plugin #830

merged 5 commits into from
Sep 23, 2024

Conversation

narimantos
Copy link
Contributor

Closes: #773

@narimantos narimantos marked this pull request as draft August 21, 2024 12:33
@narimantos narimantos force-pushed the 773-create-class-for-windows-network-interface-plugin branch 2 times, most recently from 6194955 to faf13e8 Compare August 21, 2024 12:40
@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.65101% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.89%. Comparing base (c5bf1ed) to head (7b50abd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/network.py 97.93% 6 Missing ⚠️
dissect/target/plugins/os/windows/_os.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   75.59%   75.89%   +0.30%     
==========================================
  Files         311      312       +1     
  Lines       26561    26842     +281     
==========================================
+ Hits        20078    20372     +294     
+ Misses       6483     6470      -13
Flag Coverage Δ
unittests 75.89% <97.65%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@narimantos narimantos force-pushed the 773-create-class-for-windows-network-interface-plugin branch 2 times, most recently from f727ae6 to 831ea5a Compare August 21, 2024 12:52
Schamper
Schamper requested changes Aug 21, 2024
View reviewed changes
dissect/target/helpers/record.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/helpers/record.py Outdated Show resolved Hide resolved
cecinestpasunepipe
cecinestpasunepipe requested changes Aug 21, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
@narimantos narimantos force-pushed the 773-create-class-for-windows-network-interface-plugin branch 2 times, most recently from 102a238 to 544ab7b Compare August 23, 2024 14:36
cecinestpasunepipe
cecinestpasunepipe requested changes Aug 26, 2024
View reviewed changes
tests/plugins/os/windows/test_network.py Outdated Show resolved Hide resolved
tests/plugins/os/windows/test_network.py Outdated Show resolved Hide resolved
@narimantos narimantos force-pushed the 773-create-class-for-windows-network-interface-plugin branch from 5d83db9 to 86c3800 Compare August 27, 2024 12:30
@narimantos narimantos marked this pull request as ready for review August 27, 2024 12:34
Miauwkeru
Miauwkeru requested changes Aug 28, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
tests/plugins/os/windows/test_network.py Outdated Show resolved Hide resolved
tests/plugins/os/windows/test_network.py Outdated Show resolved Hide resolved
tests/plugins/os/windows/test_network.py Show resolved Hide resolved
dissect/target/helpers/record.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Schamper
Schamper requested changes Aug 28, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 2, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 2, 2024
View reviewed changes
tests/plugins/os/windows/test_network.py Outdated Show resolved Hide resolved
tests/plugins/os/windows/test_network.py Show resolved Hide resolved
Schamper
Schamper requested changes Sep 3, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 3, 2024
View reviewed changes
tests/plugins/os/windows/test_network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 5, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 5, 2024
View reviewed changes
tests/plugins/os/windows/test_network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 11, 2024
View reviewed changes
dissect/target/plugins/general/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
pyrco
pyrco previously requested changes Sep 12, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 18, 2024
View reviewed changes
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
@narimantos narimantos force-pushed the 773-create-class-for-windows-network-interface-plugin branch from 4f9a5c7 to 57d5adb Compare September 18, 2024 11:07
Schamper
Schamper previously requested changes Sep 20, 2024
View reviewed changes
dissect/target/helpers/record.py Outdated Show resolved Hide resolved
Miauwkeru
Miauwkeru requested changes Sep 20, 2024
View reviewed changes
tests/plugins/general/test_network.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/network.py Outdated Show resolved Hide resolved
@narimantos narimantos dismissed pyrco’s stale review September 20, 2024 13:10

Implemented his request for change. But doesn't have to wait for approval

@Miauwkeru Miauwkeru dismissed Schamper’s stale review September 23, 2024 08:35

Changes requested where implemented

@Miauwkeru Miauwkeru merged commit 765c668 into main Sep 23, 2024
18 checks passed
@Miauwkeru Miauwkeru deleted the 773-create-class-for-windows-network-interface-plugin branch September 23, 2024 08:36
Schamper
Schamper reviewed Sep 23, 2024
View reviewed changes
dissect/target/helpers/record.py
@@ -144,14 +144,14 @@ def DynamicDescriptor(types): # noqa
)

COMMON_INTERFACE_ELEMENTS = [
("string", "source"),
Copy link
Member

@Schamper Schamper Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the bottom in a new PR? @narimantos @Miauwkeru

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#862

This was referenced Oct 1, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecinestpasunepipe cecinestpasunepipe cecinestpasunepipe left review comments

@Miauwkeru Miauwkeru Miauwkeru approved these changes

@Schamper Schamper Schamper left review comments

@pyrco pyrco pyrco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Windows class for network interface plugin
5 participants
@narimantos @Miauwkeru @Schamper @pyrco @cecinestpasunepipe