Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic locale fixes for RHEL #840

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Sep 4, 2024

This PR adds some small locale fixes for RHEL targets.

Schamper
Schamper previously approved these changes Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (905f5e6) to head (ded1f97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/unix/linux/_os.py 50.00% 1 Missing ⚠️
dissect/target/plugins/os/unix/locale.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   75.53%   75.52%   -0.01%     
==========================================
  Files         305      305              
  Lines       26356    26362       +6     
==========================================
+ Hits        19907    19911       +4     
- Misses       6449     6451       +2     
Flag Coverage Δ
unittests 75.52% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper
Copy link
Member

Schamper commented Sep 5, 2024

Can you satisfy the linter?

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Sep 5, 2024

Fixed with ded1f97.

@Schamper Schamper merged commit 85082d4 into fox-it:main Sep 6, 2024
18 checks passed
@JSCU-CNI JSCU-CNI deleted the redhat-fixes branch September 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants