Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to unset allow_other option for FUSE for target-mount #844

Merged

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Sep 10, 2024

Fixes #683

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.61%. Comparing base (f2b2a24) to head (f69d81b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/tools/mount.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   75.62%   75.61%   -0.01%     
==========================================
  Files         311      311              
  Lines       26544    26551       +7     
==========================================
+ Hits        20074    20077       +3     
- Misses       6470     6474       +4     
Flag Coverage Δ
unittests 75.61% <45.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dissect/target/tools/mount.py Outdated Show resolved Hide resolved
dissect/target/tools/mount.py Outdated Show resolved Hide resolved
dissect/target/tools/mount.py Outdated Show resolved Hide resolved
dissect/target/tools/mount.py Outdated Show resolved Hide resolved
dissect/target/tools/mount.py Show resolved Hide resolved
Schamper
Schamper previously approved these changes Sep 10, 2024
@Poeloe Poeloe merged commit acb8d15 into main Sep 12, 2024
16 of 18 checks passed
@Poeloe Poeloe deleted the feature/add-option-to-unset-allow_other-option-for-target-mount branch September 12, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FUSE error because of allow_other
3 participants