-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve argument parsing of the mqtt loader #850
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
+ Coverage 75.89% 76.19% +0.29%
==========================================
Files 312 310 -2
Lines 26842 26674 -168
==========================================
- Hits 20372 20323 -49
+ Misses 6470 6351 -119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
67c028f
to
5f2358a
Compare
897ce76
to
9499af4
Compare
0c079ca
to
b6b55a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to remove the host/ip checks. I don't think it is worth the aded complexity as the broker connection could fail due to a number of reasons anyway.
cd67365
to
440f7ec
Compare
The hostname is already included in the payload
File could be deleted between check and use
This way we do not have scope imports from loaders.mqtt to the test body.
The benefits do not outweigh the cost in complexity
Only a single test is using the mock and it is a single line to set up. Note that using the context manager is only required when you want the mock teared down during the test.
440f7ec
to
dc1ed23
Compare
This PR improved upon the argument parsing of the mqtt loader.
More specifically,
Additionally,
CALLID
messagesCloses #849