-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve running docker container parsing #853
Merged
Schamper
merged 6 commits into
fox-it:main
from
JSCU-CNI:fix/docker-running-container-ports
Sep 23, 2024
Merged
Improve running docker container parsing #853
Schamper
merged 6 commits into
fox-it:main
from
JSCU-CNI:fix/docker-running-container-ports
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSCU-CNI
force-pushed
the
fix/docker-running-container-ports
branch
from
September 18, 2024 09:22
a95e2b7
to
fd5bf48
Compare
Schamper
requested changes
Sep 19, 2024
Co-authored-by: Erik Schamper <[email protected]>
Schamper
previously approved these changes
Sep 20, 2024
Schamper
approved these changes
Sep 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 76.19% 76.16% -0.03%
==========================================
Files 310 310
Lines 26674 26688 +14
==========================================
+ Hits 20323 20328 +5
- Misses 6351 6360 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the parsing of running docker containers. We've added a regression test to make sure this stays fixed.