Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve running docker container parsing #853

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

JSCU-CNI
Copy link
Contributor

This PR improves the parsing of running docker containers. We've added a regression test to make sure this stays fixed.

@JSCU-CNI JSCU-CNI force-pushed the fix/docker-running-container-ports branch from a95e2b7 to fd5bf48 Compare September 18, 2024 09:22
dissect/target/plugins/apps/container/docker.py Outdated Show resolved Hide resolved
dissect/target/plugins/apps/container/docker.py Outdated Show resolved Hide resolved
dissect/target/plugins/apps/container/docker.py Outdated Show resolved Hide resolved
Schamper
Schamper previously approved these changes Sep 20, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes missing coverage. Please review.

Project coverage is 76.16%. Comparing base (8387c15) to head (f54c520).

Files with missing lines Patch % Lines
dissect/target/plugins/apps/container/docker.py 56.75% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   76.19%   76.16%   -0.03%     
==========================================
  Files         310      310              
  Lines       26674    26688      +14     
==========================================
+ Hits        20323    20328       +5     
- Misses       6351     6360       +9     
Flag Coverage Δ
unittests 76.16% <56.75%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 60cc4fb into fox-it:main Sep 23, 2024
16 of 18 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/docker-running-container-ports branch September 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants