Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improvements for VMware Workstation #854

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Sep 18, 2024

This PR adds support for VMware Workstation child detection on Linux and introduces a new VMware drag-and-drop artifact plugin.

Fixes #882 and fixes #883.

@JSCU-CNI JSCU-CNI changed the title Add improvements for vmware workstation Add improvements for VMware Workstation Sep 19, 2024
@EinatFox
Copy link

EinatFox commented Oct 2, 2024

Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.41%. Comparing base (b96029a) to head (d69511c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../plugins/apps/virtualization/vmware_workstation.py 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   76.34%   76.41%   +0.06%     
==========================================
  Files         313      314       +1     
  Lines       26883    26918      +35     
==========================================
+ Hits        20524    20569      +45     
+ Misses       6359     6349      -10     
Flag Coverage Δ
unittests 76.41% <95.34%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit d0eba16 into fox-it:main Oct 7, 2024
18 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/vmware-workstation branch October 7, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VMware workstation drag-and-drop artifact plugin Add support for Linux VMware workstation children
3 participants