Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mark home directories as having a posix or windows flavor #892

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

twiggler
Copy link
Contributor

@twiggler twiggler commented Oct 8, 2024

  • Explicitly mark home directories as either posix_path or windows_path
  • Add missing unit test for parsing of users on windows and unix

Closes #891

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.44%. Comparing base (76dfe96) to head (932a86b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   76.44%   76.44%           
=======================================
  Files         314      314           
  Lines       26928    26930    +2     
=======================================
+ Hits        20585    20587    +2     
  Misses       6343     6343           
Flag Coverage Δ
unittests 76.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dissect/target/plugins/os/unix/_os.py Outdated Show resolved Hide resolved
dissect/target/plugins/os/windows/_os.py Outdated Show resolved Hide resolved
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small question, looks good otherwise.

tests/plugins/os/unix/bsd/citrix/test__os.py Show resolved Hide resolved
dissect/target/plugins/os/unix/_os.py Outdated Show resolved Hide resolved
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make the title slightly more descriptive this looks good to me!

@twiggler twiggler changed the title Fix home paths Explicitly mark home directories as having a posix or windows flavor Oct 9, 2024
@twiggler twiggler merged commit 45bacf3 into main Oct 9, 2024
18 checks passed
@twiggler twiggler deleted the fix-home-paths branch October 9, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit path comparison for user home directories
2 participants